Migrate PumpSteer sensors to SensorEntity and native_value/unit APIs#179
Merged
JohanAlvedal merged 1 commit intocodex/01from Jan 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SensorEntitybest practices by using native value/unit APIs and modern imports while keeping existing control logic intact.Description
PumpSteerSensorandPumpSteerMLSensorto inherit fromSensorEntityand update imports to usehomeassistant.components.sensor.state/unit_of_measurementusage withnative_value/native_unit_of_measurementand useSensorDeviceClass.TEMPERATUREandSensorStateClass.MEASUREMENTfor the main sensor._attr_availableand set the entity icon via_attr_icon, while ensuring theattributesdict does not includefriendly_name,unit_of_measurement,device_class, oriconkeys; thefake_outdoor_temperatureattribute is populated from the native value with one decimal place.Testing
pytest -qtwice in the workspace; collection failed both times withModuleNotFoundError: No module named 'homeassistant'due to the test environment not providing the Home Assistant package.Codex Task