refactor(engine/actor): remove useless duplicate and push in registerComponent + add unique ID to ActorComponent

.changeset/tangy-ravens-reply.md

@@ -0,0 +1,5 @@
+---
+"@jolly-pixel/engine": patch
+---
+
+Remove useless duplication and push of components in Actor.registerComponent + Add unique ID (index) to ActorComponent

package.json

@@ -36,7 +36,7 @@
     "@changesets/cli": "^2.9.2",
     "@openally/config.eslint": "^2.2.0",
     "@openally/config.typescript": "1.2.1",
-    "@types/node": "^25.0.2",
+    "@types/node": "25.2.3",
     "@types/three": "^0.182.0",
     "c8": "^10.1.3",
     "electron": "^40.0.0",

packages/engine/src/actor/Actor.ts

@@ -84,14 +84,6 @@ export class Actor extends ActorTree {
   ): this {
     const [options, callback] = args;
     const component = new componentClass(this, options);
-    if (this.components.indexOf(component) === -1) {
-      this.components.push(component);
-    }
-
-    const index = this.gameInstance.scene.componentsToBeStarted.indexOf(component);
-    if (index === -1) {
-      this.gameInstance.scene.componentsToBeStarted.push(component);
-    }
 
     callback?.(component as InstanceType<T>);
     if (this.awoken) {
@@ -109,14 +101,6 @@ export class Actor extends ActorTree {
   ): InstanceType<T> {
     const [options] = args;
     const component = new componentClass(this, options);
-    if (this.components.indexOf(component) === -1) {
-      this.components.push(component);
-    }
-
-    const index = this.gameInstance.scene.componentsToBeStarted.indexOf(component);
-    if (index === -1) {
-      this.gameInstance.scene.componentsToBeStarted.push(component);
-    }
 
     if (this.awoken) {
       component.awake?.();

packages/engine/src/actor/ActorComponent.ts

@@ -19,6 +19,17 @@ export type ActorComponentEvents = {
 };
 
 export class ActorComponent extends EventEmitter<ActorComponentEvents> implements Component {
+  protected static Id = 0;
+
+  static generateNextId() {
+    return this.Id++;
+  }
+
+  static clearId() {
+    this.Id = 0;
+  }
+
+  id = ActorComponent.generateNextId();
   actor: Actor;
   typeName: FreeComponentEnum;
 

packages/engine/test/ActorComponent.spec.ts

@@ -1,12 +1,16 @@
 // Import Node.js Dependencies
-import { describe, test } from "node:test";
+import { describe, test, beforeEach } from "node:test";
 import assert from "node:assert/strict";
 
 // Import Internal Dependencies
 import { ActorComponent } from "../src/index.ts";
 import { createActor } from "./mocks.ts";
 
 describe("ActorComponent", () => {
+  beforeEach(() => {
+    ActorComponent.clearId();
+  });
+
   test("should register component to actor and add to components to be started", () => {
     const fakeActor = createActor();
 
@@ -19,6 +23,7 @@ describe("ActorComponent", () => {
     assert.deepEqual(fakeActor.components, [component]);
     assert.deepEqual(fakeActor.gameInstance.scene.componentsToBeStarted, [component]);
     assert.equal(component.actor, fakeActor);
+    assert.equal(component.id, 0);
     assert.equal(component.typeName, "TestComponent");
     assert.equal(component.pendingForDestruction, false);
   });
@@ -40,6 +45,8 @@ describe("ActorComponent", () => {
 
     assert.deepEqual(fakeActor.components, [component1, component2]);
     assert.deepEqual(fakeActor.gameInstance.scene.componentsToBeStarted, [component1, component2]);
+    assert.equal(component1.id, 0);
+    assert.equal(component2.id, 1);
   });
 
   test("should not be destroyed initially", () => {

packages/engine/test/tsconfig.json

@@ -0,0 +1,12 @@
+{
+  "extends": "../../../tsconfig.base.json",
+  "compilerOptions": {
+    "rootDir": "..",
+    "noEmit": true,
+    "composite": false
+  },
+  "include": [
+    "../src",
+    "."
+  ]
+}