Merged
Conversation
Contributor
Author
|
Okay, updated to use the released version of the server. I also found the issue with the CLI being broken; that has to do with Node being weird with binding to "localhost" when it's IPv6 vs connecting to "localhost". The latter assumes IPv4 would also be there, which fails and just drops the connection entirely. If you were wondering why the sed hacking into .screepsrc, that's why. |
Jomik
approved these changes
Apr 2, 2026
Jomik
requested changes
Apr 2, 2026
Owner
Jomik
left a comment
There was a problem hiding this comment.
There are some checks on matrix.node that we need to adjust, probably to use 22 if that is what official will target.
This is just so that the "official" server is without the -node24.
Jomik
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the bare minimum needed to make it build and run v4.3.0-beta, which runs on at least Node 22 (I've picked 24 since that's what o4 confirmed they were running on). I'm not sure how to manage publishing that with a beta tag, but that's what I've been testing on.
Known issues:
npm run clidoesn't work; there appears to be an issue with the beta cli tool, so you'd have tonetcat localhost 21026from within the container at the moment (which means building your own image and addnetcat-openbsdto the list of stuffaptinstalls