Skip to content

added infomaniak authenticator#307

Merged
JonasAlfredsson merged 1 commit intoJonasAlfredsson:masterfrom
bcrickboom:infomaniak-authenticator
Feb 12, 2025
Merged

added infomaniak authenticator#307
JonasAlfredsson merged 1 commit intoJonasAlfredsson:masterfrom
bcrickboom:infomaniak-authenticator

Conversation

@bcrickboom
Copy link
Copy Markdown
Contributor

Hi Jonas,

I've added the Infomaniak Authenticator and tested it.
Everything works well as soon as the RSA_KEY_SIZE env var is set to 4096.

Thanks for this awesome Docker image!

@JonasAlfredsson
Copy link
Copy Markdown
Owner

Hi bcrickboom,

Thanks for the PR. I see no issue merging this, but I don't find any info why the key size needs to be 4096? Is this still true of elliptic curve (the default) is requested instead?

@bcrickboom
Copy link
Copy Markdown
Contributor Author

Hi Jonas,

Thanks for your reactivity!

The 4096 value comes from this ReadMe.

Benoit

@JonasAlfredsson
Copy link
Copy Markdown
Owner

Yeah, I can see that they use 4096 in their examples, but they never mention that it is required.

Why I ask is because this image use ECDSA instead of RSA by default, and then the RSA_KEY_SIZE doesn't matter because it is not used. So stating that this value is required seems weird :O

@bcrickboom
Copy link
Copy Markdown
Contributor Author

Apologies, I was to quick on this.
So I've just tested with Infomaniak, without the RSA_KEY_SIZE and everything is OK. The generated certificate uses ECDSA:
Signature Algorithm: ecdsa-with-SHA384

Thanks again!

@JonasAlfredsson JonasAlfredsson merged commit cd1ef7e into JonasAlfredsson:master Feb 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants