Add tests for buildFolderTree and create utility functions for test data

Author: JonathanPiaget

src/composables/__tests__/useFolderTree.test.ts

@@ -0,0 +1,60 @@
+import { describe, expect, it } from 'vitest';
+import {
+	createNestedTreeNodes,
+	createSimpleTreeNodes,
+} from '../../test-utils/bookmarkFactory';
+import { buildFolderTree } from '../useFolderTree';
+
+describe('buildFolderTree', () => {
+	it('filters out bookmarks and returns only folders', () => {
+		const nodes = createSimpleTreeNodes();
+
+		const tree = buildFolderTree(nodes);
+
+		expect(tree).toHaveLength(2);
+		expect(tree[0].title).toBe('Work');
+		expect(tree[1].title).toBe('Personal');
+	});
+
+	it('sets empty path for root-level folders', () => {
+		const nodes = createSimpleTreeNodes();
+
+		const tree = buildFolderTree(nodes);
+
+		expect(tree[0].path).toBe('');
+		expect(tree[1].path).toBe('');
+	});
+
+	it('builds hierarchical paths using " > " separator', () => {
+		const nodes = createNestedTreeNodes();
+
+		const tree = buildFolderTree(nodes);
+
+		expect(tree.find((f) => f.id === '1')?.path).toBe('');
+		expect(tree.find((f) => f.id === '2')?.path).toBe('Books');
+		expect(tree.find((f) => f.id === '3')?.path).toBe('Books > Fiction');
+	});
+
+	it('assigns children array to parent folders', () => {
+		const nodes = createNestedTreeNodes();
+
+		const tree = buildFolderTree(nodes);
+		const books = tree.find((f) => f.id === '1');
+		const fiction = tree.find((f) => f.id === '2');
+
+		expect(books?.children).toHaveLength(1);
+		expect(books?.children?.[0].id).toBe('2');
+		expect(fiction?.children).toHaveLength(1);
+		expect(fiction?.children?.[0].id).toBe('3');
+	});
+
+	it('flattens all folders into a single array', () => {
+		const nodes = createNestedTreeNodes();
+
+		const tree = buildFolderTree(nodes);
+
+		// Books + Fiction + Sci-Fi = 3 folders
+		expect(tree).toHaveLength(3);
+		expect(tree.map((f) => f.title)).toEqual(['Books', 'Fiction', 'Sci-Fi']);
+	});
+});

src/composables/useFolderTree.ts

@@ -11,48 +11,46 @@ export interface BookmarkFolder {
 	children?: BookmarkFolder[];
 }
 
-export function useFolderTree() {
-	const allFolders = ref<BookmarkFolder[]>([]);
-	const folderMap = ref<Map<string, BookmarkFolder>>(new Map());
+export const buildFolderTree = (
+	nodes: BookmarkTreeNode[],
+	parentPath = '',
+): BookmarkFolder[] => {
+	const folders: BookmarkFolder[] = [];
 
-	const buildFolderTree = (
-		nodes: BookmarkTreeNode[],
-		parentPath = '',
-		level = 0,
-	): BookmarkFolder[] => {
-		const folders: BookmarkFolder[] = [];
-
-		for (const node of nodes) {
-			if (!node.url) {
-				const folder: BookmarkFolder = {
-					id: node.id,
-					title: node.title,
-					path: parentPath,
-					parentId: node.parentId,
-					children: [],
-				};
-
-				folders.push(folder);
-
-				if (node.children) {
-					const currentPath = parentPath
-						? `${parentPath} > ${node.title}`
-						: node.title;
-					const childFolders = buildFolderTree(
-						node.children,
-						currentPath,
-						level + 1,
-					);
-					folder.children = childFolders.filter(
-						(child) => child.parentId === node.id,
-					);
-					folders.push(...childFolders);
-				}
-			}
+	for (const node of nodes) {
+		if (node.url) continue;
+
+		const folder: BookmarkFolder = {
+			id: node.id,
+			title: node.title,
+			path: parentPath,
+			parentId: node.parentId,
+			children: [],
+		};
+
+		folders.push(folder);
+
+		if (node.children && node.children.length > 0) {
+			const currentPath = parentPath
+				? `${parentPath} > ${node.title}`
+				: node.title;
+
+			const childFolders = buildFolderTree(node.children, currentPath);
+
+			folder.children = childFolders.filter(
+				(child) => child.parentId === node.id,
+			);
+
+			folders.push(...childFolders);
 		}
+	}
 
-		return folders;
-	};
+	return folders;
+};
+
+export function useFolderTree() {
+	const folderMap = ref<Map<string, BookmarkFolder>>(new Map());
+	const allFolders = ref<BookmarkFolder[]>([]);
 
 	const loadFolders = async () => {
 		try {

src/test-utils/bookmarkFactory.ts

@@ -155,3 +155,42 @@ export function createEdgeCaseFolders(): BookmarkFolder[] {
 		createFolder({ title: 'a' }), // Lowercase single char
 	];
 }
+
+/**
+ * Preset: Simple tree structure for testing buildFolderTree
+ */
+export function createSimpleTreeNodes(): BookmarkTreeNode[] {
+	return [
+		createNode({ id: '1', title: 'Work', parentId: '0' }),
+		createNode({ id: '2', title: 'Personal', parentId: '0' }),
+		createNode({ title: 'Bookmark', url: 'https://example.com' }),
+	];
+}
+
+/**
+ * Preset: Nested tree structure for testing buildFolderTree
+ */
+export function createNestedTreeNodes(): BookmarkTreeNode[] {
+	return [
+		createNode({
+			id: '1',
+			title: 'Books',
+			parentId: '0',
+			children: [
+				createNode({
+					id: '2',
+					title: 'Fiction',
+					parentId: '1',
+					children: [
+						createNode({
+							id: '3',
+							title: 'Sci-Fi',
+							parentId: '2',
+						}),
+					],
+				}),
+				createNode({ title: 'Book URL', url: 'https://example.com' }),
+			],
+		}),
+	];
+}