Skip to content

feat: add spacer element for layout spacing#1178

Merged
bcordis merged 1 commit intodevelopmentfrom
feature/spacer-element
Mar 19, 2026
Merged

feat: add spacer element for layout spacing#1178
bcordis merged 1 commit intodevelopmentfrom
feature/spacer-element

Conversation

@bcordis
Copy link
Member

@bcordis bcordis commented Mar 19, 2026

Summary

Adds a blank spacer element to the Layout Editor for visual spacing, dividers, and layout gaps.

How it works

  • Renders   wrapped in the chosen HTML element tag (div, p, etc.)
  • Custom CSS class field lets users add spacing classes (e.g., my-3, border-bottom)
  • Row/column/colspan controls for positioning in the layout grid
  • Default element type is div (option 8)

Contexts supported

  • Messages list (no prefix)
  • Message details (d prefix)
  • Teacher list (ts prefix)
  • Teacher details (td prefix)

Files changed

  • template.xml — spacer fields added to 4 context fieldsets
  • Cwmlisting.phpspacer added to standard params + rendering case
  • Language filesJBS_TPL_SPACER string added and synced

Test plan

  • Open template editor → spacer element visible in each context
  • Set spacer row > 0 → renders empty div on frontend
  • Add custom class (e.g., my-4 border-bottom) → applied to output
  • Change element type to h2/p/blockquote → wraps correctly
  • All 538 PHPUnit tests pass
  • PHP syntax clean

🤖 Generated with Claude Code

Add 3 repeatable spacer elements (Spacer 1/2/3) to the Layout Editor
for visual spacing, dividers, and layout gaps. Each spacer can be
placed on a different row with its own column, colspan, HTML element
type, and custom CSS class.

Available in all contexts: messages list, message details, teacher
list, teacher details.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bcordis bcordis force-pushed the feature/spacer-element branch from 4b3e9db to 0e18fe5 Compare March 19, 2026 03:17
@bcordis bcordis self-assigned this Mar 19, 2026
@bcordis bcordis added php Pull requests that update Php code priority: low Nice to have labels Mar 19, 2026
@bcordis bcordis added this to the v10.3.0 milestone Mar 19, 2026
@bcordis bcordis moved this from Triage to In Progress in Proclaim Development Mar 19, 2026
@bcordis bcordis merged commit 454f159 into development Mar 19, 2026
6 checks passed
@bcordis bcordis deleted the feature/spacer-element branch March 19, 2026 03:49
@github-project-automation github-project-automation bot moved this from In Progress to Done in Proclaim Development Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

php Pull requests that update Php code priority: low Nice to have

Projects

Development

Successfully merging this pull request may close these issues.

1 participant