Skip to content

[Bug fix] Solve issue when not using standard config file #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KristjanESPERANTO merged 1 commit into from
Mar 9, 2025
Merged

[Bug fix] Solve issue when not using standard config file #320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion node_helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
const defaults = require(__dirname + "/../../js/defaults.js");
let configFilename = path.resolve(__dirname + "/../../config/config.js");
if (typeof(global.configuration_file) !== "undefined") {
configFilename = global.configuration_file;
configFilename = path.resolve(__dirname + "/../../"+global.configuration_file);
}

this.thisConfig = {};
Expand Down Expand Up @@ -226,7 +226,7 @@
// now check for installed modules
fs.readdir(path.resolve(__dirname + "/.."), function(err, files) {
const installedModules = files.filter(f => ['node_modules', 'default', 'README.md'].indexOf(f) === -1);
installedModules.forEach((dir, i, a) => {

Check warning on line 229 in node_helper.js

View workflow job for this annotation

GitHub Actions / code-quality 

'a' is defined but never used
self.addModule(dir, (i === installedModules.length - 1));
});
});
Expand Down Expand Up @@ -272,8 +272,8 @@
// check for available updates
let stat;
try {
stat = fs.statSync(path.join(modulePath, '.git'));

Check warning on line 275 in node_helper.js

View workflow job for this annotation

GitHub Actions / code-quality 

'stat' is assigned a value but never used
} catch (err) {

Check warning on line 276 in node_helper.js

View workflow job for this annotation

GitHub Actions / code-quality 

'err' is defined but never used
// Error when directory .git doesn't exist
// This module is not managed with git, skip
return;
Expand Down
Loading