Implemented All Requests For Voice Messaging Endpoints by KiPageFault · Pull Request #223 · Jordan-Prescott/odins-spear

KiPageFault · 2025-03-19T13:32:32Z

Checklist

Reference a related issue in the repository.
Provide a description of the proposed changes.
Ensure that code follows the project's style guidelines. Github linter checks should pass.
Update documentation as necessary.
Verify that all tests pass.

Reviewer Only

Created File Checking And Loading CSV's Via Pandas In Utility Added Additional File Exceptions Polished Voice Messaging Endpoints

Fixed None Pythonic Evaluation To Satisfy Lint Error

Removed Log Formatting When Specifying No Raw Type To Satisfy Lint Error

Removed Invalid Log Formatting To Satisfy Lint Error

KiPageFault · 2025-03-25T14:35:58Z

Added All Necessary Documentation

Jordan-Prescott

Some adjustments

src/odins_spear/exceptions.py

Jordan-Prescott · 2025-04-07T08:24:07Z

src/odins_spear/scripter.py

+        self,
+        service_provider_id: str,
+        group_id: str,
+        service_pack_id: str = None


Although 14 are good at service packs for specific users we don't know if other companies are. Can you remove this param and update the method accordingly. I would change this to a list of users and set to None, if the user passes us the list of users we will do for those only if not we will apply to all. - What do you think?

Jordan-Prescott · 2025-04-07T08:26:31Z

src/odins_spear/scripter.py

+        self,
+        service_provider_id: str,
+        group_id: str, 
+        new_password: str


Same here as above should we add a list of users? Additionally we could have new_password as optional and if they do not specify one we could use the api.generate_password to get one/ a unique for each. Final thought we would need to pass these details back to the user.

The optional password is a great idea! However for the list of users. The alteration of vm_portal_bulk_password_set in the powered by odins spear docs will allow users to perform this action themselves

src/odins_spear/scripter.py

src/odins_spear/scripts/vm_auto_login.py

src/odins_spear/scripts/vm_portal_bulk_password_set.py

Jordan-Prescott · 2025-04-07T08:51:16Z

src/odins_spear/scripts/vm_portal_bulk_password_set.py

+        )
+
+    logger.info("Successfully Set Group User Portal Passcodes")
+


Same as above is there anything we would return to the user?

I dont believe there is anything to tangibly return bar a list of affected users. Due to the scripts nature it is impossible to return the users with their new password as it is it obfuscated in the request

src/odins_spear/scripts/vm_portal_bulk_password_set.py

src/odins_spear/utils/filers.py

…ing bulk_password_reset script

Jordan-Prescott

Still some parts to iron these out

Jordan-Prescott · 2025-05-09T12:15:19Z

src/odins_spear/scripts/bulk_password_reset.py


 def main(
-    api, service_provider_id: str, group_id: str, users: list, password_type: str
+    api, service_provider_id: str, group_id: str, users: list, password_type: str, static_password: str


I like this static password param nice work - have you updated docs to reflect this both in codebase and the docs online?

Jordan-Prescott · 2025-05-09T12:15:52Z

src/odins_spear/scripts/vm_auto_login.py

@@ -0,0 +1,54 @@
+def main(api, service_provider_id: str, group_id: str, service_pack_id: str = None):


Commented on this above, the service pack id here I think we should remove.

src/odins_spear/endpoints/voice_messaging.py

…ed Service Packs From VM Auto Login

Jordan-Prescott

Few bits but there are a lot of changes here so it may take us a couple of times to get it there.

Jordan-Prescott · 2025-05-28T08:20:47Z

external_call_forwarding_identifiers.csv

This needs removing - be careful about what you commit and push.

What's useful is having another environment on your computer where you have the latest v of OS for these kind of things.

Jordan-Prescott · 2025-05-28T08:22:23Z

src/odins_spear/endpoints/voice_messaging.py

@@ -0,0 +1,574 @@
+from .base_endpoint import BaseEndpoint
+
+class VoiceMessaging(


is there no POST methods in this endpoint?

Jordan-Prescott · 2025-05-28T08:25:38Z

src/odins_spear/scripter.py

        group_id: str,
        users: list,
        password_type: str,
+        static_password: Optional[str] = None


Have you tested this with each password type? This script updates 3 types of passwords

Jordan-Prescott · 2025-05-28T08:26:33Z

src/odins_spear/scripter.py

+
+    def vm_auto_login(
+        self,
+        service_provider_id: str,


Can we add a param here to specify users and if no users specified we auto login all?

Implemented All Requests For Voice Messaging Endpoints

c976562

KiPageFault linked an issue Mar 19, 2025 that may be closed by this pull request

Voicemail Utility Scripts #215

Open

Jordan-Prescott closed this Mar 19, 2025

KiPageFault reopened this Mar 19, 2025

Billy and others added 6 commits March 25, 2025 10:27

Issue #215

ecab388

Creating VM Utility Scripts In Accordance With Issue #215.

f5645cf

Created File Checking And Loading CSV's Via Pandas In Utility Added Additional File Exceptions Polished Voice Messaging Endpoints

Update vm_auto_login.py

17acf5e

Fixed None Pythonic Evaluation To Satisfy Lint Error

Update vm_portal_bulk_password_set.py

b877e95

Removed Log Formatting When Specifying No Raw Type To Satisfy Lint Error

Update vm_portal_bulk_password_set_csv.py

8f9a58b

Removed Invalid Log Formatting To Satisfy Lint Error

Update api.py

261e41e

Billy added 2 commits April 1, 2025 09:51

Removed CSV Reading | Removed Bulk Password Set From CSV Script

4d19a61

Added Optional Service Pack Filter To vm_auto_login script

a13788e

Jordan-Prescott suggested changes Apr 9, 2025

View reviewed changes

Billy added 3 commits April 9, 2025 11:39

Slight Revisions In Accordance With Review

7ad3667

removed pandas import

e172ffb

Removed vm_portal_bulk_password_set | Now Incorporated Into Pre-exist…

0bcf4f6

…ing bulk_password_reset script

Jordan-Prescott suggested changes May 9, 2025

View reviewed changes

Billy added 2 commits May 12, 2025 08:34

Reordered Voice Messaging Endpoints and Appended # Descriptors. Remov…

f817a9d

…ed Service Packs From VM Auto Login

Updated Issue In Accordance With Merge Request

951b8d8

Jordan-Prescott suggested changes May 28, 2025

View reviewed changes

Billy added 2 commits June 30, 2025 08:52

Push

ee63fa4

Added optional user list

43841c1

		)

		logger.info("Successfully Set Group User Portal Passcodes")

		@@ -0,0 +1,54 @@
		def main(api, service_provider_id: str, group_id: str, service_pack_id: str = None):

		@@ -0,0 +1,574 @@
		from .base_endpoint import BaseEndpoint

		class VoiceMessaging(

Uh oh!

Conversation

KiPageFault commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Reviewer Only

Uh oh!

KiPageFault commented Mar 25, 2025

Uh oh!

Jordan-Prescott left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Jordan-Prescott left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jordan-Prescott left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KiPageFault commented Mar 19, 2025 •

edited

Loading