Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions docs/FAQs.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ Here we'll outline the steps required to migrate a CTA app to a GitHub Action:

1. GitHub Actions store built output on a GitHub branch rather than in a published package on npm.
As a consequence we should:

- delete `.github/workflows/release.yml` and `.github/workflows/post-release.yml`.
- update `.github/workflows/build.yml` to ensure `dist` is up to date:

Expand Down Expand Up @@ -74,20 +73,17 @@ Here we'll outline the steps required to migrate a CTA app to a GitHub Action:
pnpm remove tsup
pnpm add @vercel/ncc -D
```

- Now we need to update the `build` script in our `package.json`:

```diff
-"build": "tsup",
+"build": "ncc build src/index.ts -o dist --license licenses.txt",
```

- Our build now emits to the `dist` directory; so we'll want to avoid linting that directory by adding the following to `.eslintignore` and our `.prettierignore`:

```diff
+dist
```

- Rather than having to remember to compile each time, we'll update our pre-commit hook in `.husky/pre-commit` to build for us on each commit:

```diff
Expand Down
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"devDependencies": {
"@eslint-community/eslint-plugin-eslint-comments": "4.5.0",
"@eslint/js": "9.22.0",
"@prettier/sync": "0.5.3",
"@prettier/sync": "0.6.1",
"@release-it/conventional-changelog": "10.0.0",
"@types/eslint-plugin-markdown": "2.0.2",
"@types/git-url-parse": "16.0.0",
Expand Down Expand Up @@ -108,10 +108,10 @@
"lodash": "4.17.21",
"markdownlint": "0.37.4",
"markdownlint-cli": "0.44.0",
"prettier": "3.5.3",
"prettier-plugin-curly": "0.3.1",
"prettier-plugin-packagejson": "2.5.10",
"prettier-plugin-sh": "0.15.0",
"prettier": "3.6.1",
"prettier-plugin-curly": "0.3.2",
"prettier-plugin-packagejson": "2.5.15",
"prettier-plugin-sh": "0.17.4",
"release-it": "18.1.2",
"sentences-per-line": "0.3.0",
"tsup": "8.4.0",
Expand Down
140 changes: 69 additions & 71 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading