Skip to content

Conversation

@JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 13, 2023

Fixes #39; fixes #43.

Moves to the external jsonc-eslint-parser because:

Also removes the disparity dependency, in favor of directly telling users to run the auto-fixer. This is the strategy other plugins such as eslint-plugin-simple-import-sort take. It's simpler to implement, makes for easier-to-read error messages, and reduces the size of node_modules.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft September 13, 2023 19:31
Base automatically changed from mit-license to master September 15, 2023 16:40
@JoshuaKGoldberg
Copy link
Owner Author

From the ESLint Discord: https://discord.com/channels/688543509199716507/711686958635548723/1151961528011063296

Question: I just started overhauling an old plugin that uses a processor. I'd like to get it to use RuleTester for the rules. Is that blocked on eslint/rfcs#31 (feat: RuleTester supports processor)?

Response: Short answer: yes, you're blocked. Longer answer: it's not clear that the RFC is the right solution to this problem, and because you're not using JS, you are in a sort of "voiding your warranty" situation. 🙂
It's possible that language plugins would make this easier to solve, but there's no straightforward answer right now.

Welp.

@JoshuaKGoldberg JoshuaKGoldberg changed the title WIP ESLint 8 ESLint 8 and jsonc-eslint-parser Sep 20, 2023
@JoshuaKGoldberg JoshuaKGoldberg changed the title ESLint 8 and jsonc-eslint-parser feat!: ESLint 8 and jsonc-eslint-parser Sep 20, 2023
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 20, 2023 13:09
@JoshuaKGoldberg JoshuaKGoldberg merged commit d1a2843 into main Oct 17, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the eslint-8 branch October 17, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tooling: consider switching to jsonc-eslint-parser Bump ESLint dependency to 8.x

2 participants