-
Notifications
You must be signed in to change notification settings - Fork 1
Remove type instabilities and allow general floating point types #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is breaking because:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
=======================================
Coverage 98.65% 98.66%
=======================================
Files 46 46
Lines 1266 1269 +3
=======================================
+ Hits 1249 1252 +3
Misses 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Another instance of OrdinaryDiffEq.jl completely breaking Downgrade... I think that's because of SciML/OrdinaryDiffEq.jl#2567. The latest version of OrdinaryDiffEqDifferentiation.jl (v1.6.0) (which is installed because we don't require a compat of it) is not compatible with older versions of OrdinaryDiffEqNonlinearSolve.jl and OrdinaryDiffEqRosenbrock.jl and therefore we need the latest ones (v1.6 and v1.9 respectively). |
|
Because of yet another wrongly set compat bound in the SciML ecosystem, we also need to drop support for DiffEqCallbacks.jl v3... |
There were several type instabilities. I tried to fight them as much as I could, but in some places it might be unavoidable (e.g., creating
NodeSets from non-statically sized vectors). I also added some tests that the floating point type is preserved duringinterpolateandsolve_stationary. It should cover most of the package, but maybe not everything.I also decided to force floating point element types for
NodeSets, which makes lives easier.