Open
Conversation
kan15hk
reviewed
Nov 13, 2020
kan15hk
reviewed
Nov 13, 2020
| @@ -0,0 +1,3 @@ | |||
| public class SpawnerObject : MonoSingleton<SpawnerObject> | |||
There was a problem hiding this comment.
What is the need for the SpawnerObject? You can get spawn positions(children) without using this script
Owner
Author
There was a problem hiding this comment.
I dont want to drop any object but only the one which has spawner children, just extra precaution.
kan15hk
reviewed
Nov 13, 2020
kan15hk
reviewed
Nov 13, 2020
kan15hk
reviewed
Nov 13, 2020
kan15hk
reviewed
Nov 13, 2020
kan15hk
reviewed
Nov 13, 2020
kan15hk
reviewed
Nov 13, 2020
kan15hk
reviewed
Nov 13, 2020
kan15hk
reviewed
Nov 13, 2020
kan15hk
reviewed
Nov 13, 2020
kan15hk
reviewed
Nov 13, 2020
kan15hk
reviewed
Nov 13, 2020
kan15hk
reviewed
Nov 13, 2020
Assets/Scripts/Tank/TankService.cs
Outdated
| } else { | ||
| enemy = GameObject.Instantiate(greenTank, randomSpawnPosition, Quaternion.identity, enemyParent); | ||
| } | ||
| enemy.Health = tankData.health; |
There was a problem hiding this comment.
Pass scriptable object to enemy controller and setup enemy in that script. Single Responsibility Principle is broken as this function does too many things.
added 6 commits
November 19, 2020 23:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just for comparison, not ready for merging yet.