Conversation
marcoesters
reviewed
Dec 15, 2025
constructor/nsis/main.nsi.tmpl
Outdated
|
|
||
| # Add frozen marker file if configured | ||
| {%- if env.has_frozen %} | ||
| SetOutPath "{{ env.conda_meta }}" |
Collaborator
There was a problem hiding this comment.
SetOutPath shouldn't be necessary since it has already been set to the correct directory for the history file.
Owner
Author
There was a problem hiding this comment.
I thought the same, but we explicitly do so in other areas like for $INSTDIR so I figured it wouldn't hurt to use the explicitness here either.
Collaborator
There was a problem hiding this comment.
Fair enough. I would dedent this though - right now, these lines have a different indentation.
Owner
Author
There was a problem hiding this comment.
The dedent is not necessary because this code is inside the setup envs loop.
Co-authored-by: Marco Esters <mesters@anaconda.com>
marcoesters
reviewed
Dec 16, 2025
Co-authored-by: Marco Esters <mesters@anaconda.com>
marcoesters
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide metadata to easily protect environments (INST-622)
Related tickets:
frozen_environmentsmetadata (INST-635)Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?