release

.github/PULL_REQUEST_TEMPLATE.md

@@ -2,24 +2,24 @@
 
 Please check if your PR fulfills the following requirements:
 
-- [ ] The commit message follows our guidelines: https://github.com/JsDaddy/ngx-loader-indicator/blob/develop/CONTRIBUTING.md#commit
-- [ ] Tests for the changes have been added (for bug fixes / features)
-- [ ] Docs have been added / updated (for bug fixes / features)
+-   [ ] The commit message follows our guidelines: https://github.com/JsDaddy/ngx-loader-indicator/blob/develop/CONTRIBUTING.md#commit
+-   [ ] Tests for the changes have been added (for bug fixes / features)
+-   [ ] Docs have been added / updated (for bug fixes / features)
 
 ## PR Type
 
 What kind of change does this PR introduce?
 
 <!-- Please check the one that applies to this PR using "x". -->
 
-- [ ] Bugfix
-- [ ] Feature
-- [ ] Code style update (formatting, local variables)
-- [ ] Refactoring (no functional changes, no api changes)
-- [ ] Build related changes
-- [ ] CI related changes
-- [ ] Documentation content changes
-- [ ] Other... Please describe:
+-   [ ] Bugfix
+-   [ ] Feature
+-   [ ] Code style update (formatting, local variables)
+-   [ ] Refactoring (no functional changes, no api changes)
+-   [ ] Build related changes
+-   [ ] CI related changes
+-   [ ] Documentation content changes
+-   [ ] Other... Please describe:
 
 ## What is the current behavior?
 
@@ -31,8 +31,8 @@ Issue Number: N/A
 
 ## Does this PR introduce a breaking change?
 
-- [ ] Yes
-- [ ] No
+-   [ ] Yes
+-   [ ] No
 
 <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
 

.github/hooks/commit-msg

@@ -3,4 +3,4 @@
 set -e
 
 commit_msg=$(cat .git/COMMIT_EDITMSG)
-echo "$commit_msg" | npx  commitlint
+echo "$commit_msg" | bun commitlint

.github/hooks/pre-commit

@@ -2,21 +2,21 @@
 
 set -e
 
-npm run lint
+bun lint-staged
 
-npm run snyk:test
+# bun run snyk:test
 
-output=$(npm run type-coverage)
+output=$(bun run type-coverage)
 if echo "$output" | grep -q "lower than "; then
     echo "$output"
     exit 1  # Terminate the hook script with a non-zero exit code
 else
     echo "Type coverage is good! 🎉"
 fi
 
-npm run test
+bun run test
 
-npm run build
+bun run build
 
-npm run build:lib
+bun run build:lib
 

.github/workflows/gh-pages.yml

@@ -12,15 +12,20 @@ jobs:
             contents: write
         steps:
             - uses: actions/checkout@v4
+              with:
+                  submodules: true
 
             - uses: actions/setup-node@v4
               with:
                   node-version: 20
 
+            - uses: oven-sh/setup-bun@v2
+              with:
+                  bun-version: latest
+
             - name: Install deps
               run: |
-                  npm ci --force
-                  git submodule update --init --recursive --remote
+                  bun i
 
             - name: Semantic Release
               id: semantic-release
@@ -37,14 +42,13 @@ jobs:
                   echo "RELEASE_VERSION: $RELEASE_VERSION"
                   echo '********'
                   bash .github/workflows/scripts/replace_template.sh $RELEASE_VERSION
-                  npm run build
+                  bun run build
 
             - name: Deploy demo
-              uses: peaceiris/actions-gh-pages@v3
+              uses: peaceiris/actions-gh-pages@v4
               with:
                   github_token: ${{ secrets.GITHUB_TOKEN }}
                   publish_dir: ./dist/angular-loader/browser
-
         outputs:
             version: ${{ steps.semantic-release.outputs.new-release-version }}
 
@@ -55,7 +59,7 @@ jobs:
         steps:
             - name: Post to a Slack channel
               id: slack
-              uses: slackapi/slack-github-action@v1.26.0
+              uses: slackapi/slack-github-action@v1.27.0
               with:
                   channel-id: 'deployments'
                   payload: |

.github/workflows/publish.yml

@@ -1,4 +1,4 @@
-name: Publish npm
+name: Publish bun
 
 on:
     push:
@@ -10,17 +10,21 @@ jobs:
         runs-on: ubuntu-latest
         steps:
             - uses: actions/checkout@v4
+              with:
+                  submodules: true
+            - uses: oven-sh/setup-bun@v2
+              with:
+                  bun-version: latest
             - uses: actions/setup-node@v4
               with:
                   node-version: 20
-                  registry-url: https://registry.npmjs.org/
+                  registry-url: 'https://registry.npmjs.org'
             - name: Build library
               run: |
-                  npm ci --force
-                  git submodule update --init --recursive --remote
-                  npm run build:lib
+                  bun i
+                  bun run build:lib
             - name: Publish library
-              run: npm run publish:lib
+              run: bun run publish:lib
               env:
                   NODE_AUTH_TOKEN: ${{secrets.npm_token}}
 
@@ -63,7 +67,7 @@ jobs:
                             "type": "section",
                             "text": {
                               "type": "mrkdwn",
-                              "text": "Website URL: ${{ secrets.WEBSITE_URL || 'TBA' }}"
+                              "text": "Website URL: ${{ secrets.NPM_PACKAGE_URL || 'TBA' }}"
                             }
                           }
                         ]

.github/workflows/quality-check.yml

@@ -1,28 +1,34 @@
 name: build and quality
 
 on:
-  push:
-    branches:
-      - develop
-  pull_request:
-    branches:
-      - develop
+    push:
+        branches:
+            - develop
+    pull_request:
+        branches:
+            - develop
 
 env:
     snyk_token: ${{ secrets.SNYK_TOKEN }}
+    REF: ${{ github.head_ref || github.ref_name }}
 
 jobs:
-  quality-check:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: write
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
-        with:
-          node-version: 20
-      - name: Check quality
-        run: |
-          npm ci --force
-          git submodule update --init --recursive --remote
-          bash .github/workflows/scripts/quality.sh
+    quality-check:
+        runs-on: ubuntu-latest
+        permissions:
+            contents: write
+        steps:
+            - uses: actions/checkout@v4
+              with:
+                  submodules: true
+                  ref: ${{ env.REF }}
+            - uses: oven-sh/setup-bun@v2
+              with:
+                  bun-version: latest
+            - uses: actions/setup-node@v4
+              with:
+                  node-version: 20
+            - name: Check quality
+              run: |
+                  bun i
+                  bash .github/workflows/scripts/quality.sh

.github/workflows/scripts/quality.sh

@@ -2,21 +2,21 @@
 
 set -e
 
-npm run lint
+bun run lint
 
-npm run snyk:auth -- $snyk_token
-npm run snyk:test
+# bun run snyk:auth -- $snyk_token
+# bun run snyk:test
 
-output=$(npm run type-coverage)
+output=$(bun run type-coverage)
 if echo "$output" | grep -q "lower than "; then
     echo "$output"
     exit 1  # Terminate the hook script with a non-zero exit code
 else
     echo "Type coverage is good! 🎉"
 fi
 
-npm run test
+bun run test
 
-npm run build
+bun run build
 
-npm run build:lib
+bun run build:lib

.lintstagedrc

@@ -0,0 +1,7 @@
+{
+    "*.{ts,js,json}": [
+        "eslint --report-unused-disable-directives --max-warnings 0 --fix",
+        "prettier . --write"
+    ],
+    "*.scss": "stylelint --fix"
+}

.releaserc.yaml

@@ -1,7 +1,7 @@
 branches:
-  - develop
+    - develop
 
 plugins:
-  - '@semantic-release/commit-analyzer'
-  - '@semantic-release/github'
-  - 'semantic-release-export-data'
+    - '@semantic-release/commit-analyzer'
+    - '@semantic-release/github'
+    - 'semantic-release-export-data'

.stylelintignore

@@ -3,6 +3,7 @@
 /tmp
 /out-tsc
 /bazel-out
+/src/styles.scss
 
 # Node
 /node_modules

.stylelintrc.json

@@ -3,6 +3,9 @@
     "customSyntax": "postcss-scss",
     "plugins": ["stylelint-prettier"],
     "rules": {
+        "no-empty-source": null,
+        "scss/comment-no-empty": null,
+        "no-descending-specificity": null,
         "prettier/prettier": true,
         "selector-type-no-unknown": [
             true,

CHANGELOG.md

@@ -1,50 +1,57 @@
+# 18.0.4(2024-10-25)
+
+### Feature
+
+-   add tailwind
+-   change interface to type, remove prefix "I"
+-   update dependencies
+-   add ESLint strict rules
+
 # 17.3.2(2024-03-29)
 
 ### Feature
 
-- change decorators to signals
+-   change decorators to signals
 
 <a name="17.0.0"></a>
 
 # 17.0.0(2023-11-28)
 
 ### Feature
 
-- update ng 17.x
+-   update ng 17.x
 
 <a name="17.0.0"></a>
 
-
 # 16.0.1(2023-10-03)
 
 ### Feature
 
-- update dependencies
+-   update dependencies
 
 # 16.0.0(2023-07-07)
 
 ### Feature
 
-- update ng 16.x
+-   update ng 16.x
 
 <a name="16.0.0"></a>
 
 # 15.0.0(2022-26-12)
 
 ### Feature
--  update to ng15
 
-<a name="15.0.0"></a>
+-   update to ng15
 
+<a name="15.0.0"></a>
 
 <a name="6.0.0"></a>
-# [6.0.0 base functionality] (2018-05-17)
 
+# [6.0.0 base functionality] (2018-05-17)
 
 <a name="6.1.0"></a>
+
 # [6.1.0 base functionality] (2018-05-21)
- 
+
 <p>Custom styles(background, color, size) for image and wrapper</p>
 <p>Custom animations for image rotation</p>
-
-

CONTRIBUTING.md

@@ -8,16 +8,16 @@ Please format code and markup in your issue using [github markdown](https://help
 
 ## Contributing to Source Code (Pull Requests)
 
-- If your PR changes any behavior or fixes an issue, it should have an associated test.
-- New features should be general and as simple as possible.
-- Breaking changes should be avoided if possible.
-- All pull requests require review. No PR will be merged without a comment from a team member stating LGTM (Looks good to me).
+-   If your PR changes any behavior or fixes an issue, it should have an associated test.
+-   New features should be general and as simple as possible.
+-   Breaking changes should be avoided if possible.
+-   All pull requests require review. No PR will be merged without a comment from a team member stating LGTM (Looks good to me).
 
 ## Protractor specific rules
 
-- JavaScript style should generally follow the [Google JS style guide](https://google.github.io/styleguide/javascriptguide.xml).
-- Document public methods with jsdoc.
-- Be consistent with the code around you!
+-   JavaScript style should generally follow the [Google JS style guide](https://google.github.io/styleguide/javascriptguide.xml).
+-   Document public methods with jsdoc.
+-   Be consistent with the code around you!
 
 ## Commit Messages