Skip to content

Conversation

RomeoV
Copy link

@RomeoV RomeoV commented Sep 2, 2025

Summary

Removes calls to the non-existent logartifact function that was causing UndefVarError. Provides a temporary workaround with clear TODO comments for future implementation.

Changes

  • Commented out logartifact(mlf, exprun, plotfilename) calls in both tutorial and examples
  • Commented out rm(plotfilename) to preserve plot files since they can't be uploaded
  • Added TODO comments with reference to issue Tutorial references missing logartifact function #61
  • Added explanatory comments about the temporary workaround

Problem

The tutorial and examples called a non-existent function:

logartifact(mlf, exprun, plotfilename)  # ❌ UndefVarError: logartifact not defined

The logartifact function is not implemented in the current codebase, only listartifacts exists.

Solution

Temporary workaround until artifact upload is implemented:

# TODO: Upload the plot as an artifact when logartifact function is implemented
# See: https://github.com/JuliaAI/MLFlowClient.jl/issues/61
# logartifact(mlf, exprun, plotfilename)

# Keep the plot file since artifact upload is not yet available
# rm(plotfilename)

Benefits

  • ✅ Makes the tutorial examples functional (no more UndefVarError)
  • ✅ Preserves the intent for future artifact upload implementation
  • ✅ Keeps plot files available for manual inspection
  • ✅ Clear documentation of what needs to be implemented
  • ✅ References the tracking issue for artifact upload feature

Impact

  • Tutorial examples now run without errors
  • Users can still see generated plots (just not uploaded to MLFlow)
  • Clear path forward for implementing artifact upload functionality
  • Maintains tutorial completeness while being honest about current limitations

Test plan

  • Verified logartifact function does not exist in codebase
  • Confirmed plot files are still generated and saved locally
  • Added proper TODO comments with issue references
  • Both tutorial and example files updated consistently

Fixes #61 (temporary workaround until function is implemented)

🤖 Generated with Claude Code

Removes calls to the non-existent logartifact function that was causing
UndefVarError. The function is not implemented in the current codebase.

Changes:
- Commented out logartifact calls with TODO reference to issue JuliaAI#61
- Commented out rm(plotfilename) to keep plot files available
- Added clear comments explaining the temporary workaround

This makes the tutorial functional while preserving the intent for
future implementation when artifact upload functionality is added.

Fixes JuliaAI#61 (temporary workaround until function is implemented)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@RomeoV RomeoV mentioned this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial references missing logartifact function
1 participant