Skip to content

Remove logartifact calls from tutorial and examples #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove logartifact calls from tutorial and examples #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions docs/src/tutorial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,12 @@ end
plotfilename = "pricepaths-plot.png"
png(plotfilename)

# Upload the plot as an artifact associated with the MLFlow experiment's run
logartifact(mlf, exprun, plotfilename)
# TODO: Upload the plot as an artifact when logartifact function is implemented
# See: https://github.com/JuliaAI/MLFlowClient.jl/issues/61
# logartifact(mlf, exprun, plotfilename)

# remote temporary plot which was already uploaded in MLFlow
rm(plotfilename)
# Keep the plot file since artifact upload is not yet available
# rm(plotfilename)

# complete the experiment
updaterun(mlf, exprun, "FINISHED")
Expand Down
9 changes: 5 additions & 4 deletions examples/simple-with-mlflow.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,12 @@ end
plotfilename = "pricepaths-plot.png"
png(plotfilename)

# Upload the plot as an artifact associated with the MLFlow experiment's run
logartifact(mlf, exprun, plotfilename)
# TODO: Upload the plot as an artifact when logartifact function is implemented
# See: https://github.com/JuliaAI/MLFlowClient.jl/issues/61
# logartifact(mlf, exprun, plotfilename)

# remote temporary plot which was already uploaded in MLFlow
rm(plotfilename)
# Keep the plot file since artifact upload is not yet available
# rm(plotfilename)

# complete the experiment
updaterun(mlf, exprun, "FINISHED")