Ensure source() != source() and clean up some tests
#1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present
source() == source(), which means sources unbound to data in learning networks cannot be distinguished using==, which we view as a bug. This PR fixes this.We also move the definition of the private method
MLJBase.childrenout to tests, since it is not used for any other purpose.Moreover, we tweak its definition so that it does not depend on the overloading ofBase.incurrently in MLJModelInterface, which we would ultimately like to remove. See this discussion.The following local tests of downstream packages
(with the overloading in MLJModelInterface removed)pass: