change f_tol to f_reltol #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablaom
reviewed
May 28, 2025
ablaom
approved these changes
May 28, 2025
There was a problem hiding this comment.
Okay, this looks good to me. Thanks for stepping up here @olivierlabayle.
Since the docs make it clear that we are just passing options to Optim I agree it's fair not to tag this as breaking.
I'd like to @tlienart to have an opportunity to review. @olivierlabayle Can you ping me in two weeks if we get no further comment and you need me to merge?
tlienart
approved these changes
May 29, 2025
|
This makes sense to me, thanks both!! I'll merge but @ablaom if I could leave the release process to you that would be great 🙏🏼 |
Co-authored-by: Anthony Blaom, PhD <[email protected]>
This was referenced May 29, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #160
changes
f_toltof_reltol(notf_abstol) which is the non-breaking change according to the log message.