Skip to content

Fix localmodels bug #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ablaom merged 1 commit into from
Nov 5, 2025
Merged

Fix localmodels bug #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/model_search.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,15 @@ function localmodeltypes(modl; toplevel=false, wrappers=false)
end
end

# helper
function simple_repr(T)
# get rid of type parameters:
output = split(repr(T), "{") |> first
# get rid of qualifiers:
output = split(output, ".") |> last
return output
end

"""
localmodels(; modl=Main, wrappers=false)
localmodels(filters...; modl=Main, wrappers=false)
Expand All @@ -410,11 +419,12 @@ See also [`models`](@ref), [`load_path`](@ref).

"""
function localmodels(args...; modl=Main, kwargs...)
modeltypes = localmodeltypes(modl; kwargs...)
modeltypes = filter(M-> !isabstracttype(M), localmodeltypes(modl; kwargs...))
handles = map(modeltypes) do M
Handle(MMI.name(M), MMI.package_name(M))
name = is_wrapper(M) ? simple_repr(MMI.constructor(M)) : MMI.name(M)
Handle(name, MMI.package_name(M))
end
return filter(models(args...)) do model
ret = filter(models(args...; kwargs...)) do model
Handle(model.name, model.package_name) in handles
end
end
11 changes: 11 additions & 0 deletions test/model_search.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,5 +151,16 @@ end
@test pca ∉ models(r"PCA′")
end

@testset "https://github.com/JuliaAI/MLJModels.jl/issues/594" begin
ms = map(m->m.name, models())
ms_plus = map(m->m.name, models(; wrappers=true))
localms = map(m->m.name, localmodels())
localms_plus = map(m->m.name, localmodels(; wrappers=true))
@test !("Pipeline" in ms)
@test "Pipeline" in ms_plus
@test !("Pipeline" in localms)
@test "Pipeline" in localms_plus
end

end
true
Loading