Resolve scitype name clashes #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My remedy raised a new conflict, between (Another noteworthy conflict navigated here is |
|
Sincerely sorry for the delay and looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #31 .
This issue is quite subtle, and I can imagine this caused the developer some angst. See also JuliaAI/MLJBase.jl#1002 .
Going forward, it also recommended that one does not import the namespaces of MLJBase and MLJModelInterface simultaneously. Every name in MLJModelInterface is re-exported by MLJBase, so there shouldn't be a need to import both (that is to have both
using MLJBaseandusing MLJModelInterfacecalls). I have remedied this in the tests for this package here.