Use level names for categories #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablaom
reviewed
May 14, 2025
| :num_classes => (task == "Regression") ? -1 : length(y_classes), | ||
| :y_stat_given_feat_level => y_stat_given_feat_level, | ||
| :encoded_features => encoded_features, | ||
| :y_classes => (task == "Regression") ? nothing : y_classes, |
There was a problem hiding this comment.
This is fine but I'm curious, is there a reason to use a dictionary for the cache? More standard would be to use a named tuple, or if this needs to be mutable, a mutable struct.
There was a problem hiding this comment.
There isn't indeed and I plan to replace them all with named-tuples as in #5. Such action would be deterministic so I was waiting to merge the encoding types PR (and maybe this one) to avoid conflicts.
ablaom
reviewed
May 14, 2025
ablaom
reviewed
May 14, 2025
ablaom
reviewed
May 14, 2025
ablaom
reviewed
May 14, 2025
ablaom
reviewed
May 14, 2025
ablaom
approved these changes
May 14, 2025
Co-authored-by: Anthony Blaom, PhD <[email protected]>
Co-authored-by: Anthony Blaom, PhD <[email protected]>
Co-authored-by: Anthony Blaom, PhD <[email protected]>
Co-authored-by: Anthony Blaom, PhD <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10 it was tricky to implement because for some methods, the new columns added are not directly related to the levels of the column (eg, target encoding where it's related to the classes)