✨ NamedTuple for cache and less documentation redundancy #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This first commit is to make cache a named-tuple, another one for docstring redundancy coming inshallah. |
|
Now finished commit for docstring redundancy |
ablaom
reviewed
May 28, 2025
ablaom
approved these changes
May 28, 2025
There was a problem hiding this comment.
This was evidently a lot of work to nail some details, which is much appreciated.
Note: For future reference, this was a hard to review, because of so many whitespace changes not getting separate commits. Hopefully I didn't miss anything important. Your testing is good, so hopefully not.
|
Thank you for the point. Sorry for the spaces it's likely due to my Julia formatter being changed from the time I worked on this package originally. Feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.