- 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
Bump [compat] entry: CategoricalArrays="1.0" #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           @ablaom in the ci tests we see   | 
    
| 
           Sorry, my bad. This PR needs: 
 @EssamWisam Let me ping you when this ready.  | 
    
| 
           Looks like document generation needs: 
  | 
    
| 
           Okay, MLJ is also a doc dependency, and we cannot update the MLJ compat entry for CategoricalArrays before MLJTransforms. Documentation has a circular dependency. Note to self. Centralised, top-level documentation has its advantages. Otherwise, documentation needs to avoid depending on packages on which the package itself is a dependency. No matter. Failed doc generation does not get deployed. So plan merging, and tagging the doc problem as follow-up issue.  | 
    
| 
           @EssamWisam Ready for a review  | 
    
| 
           I found that  Looks good to me and will merge.  | 
    
Recall that CategoricalArrays 1.0 introduces new behaviour for
levels. The return value is aCategoricalArrayinstead of raw levels.As I am not familiar with the codebase for the newer encoders, I have simply replaced all calls
levelswithrawlevels, whererawlevelsmimics the old behaviour:rawlevels(A) = unwrap.(levels(A)).This PR is needed before important rollout of the CategoricalArrays="1.0" update can happen elsewhere in the MLJ ecosystem. In particular, MLJModels, needs this PR merged before it can do the update.