Skip to content

Conversation

@ablaom
Copy link
Member

@ablaom ablaom commented Oct 21, 2025

Recall that CategoricalArrays 1.0 introduces new behaviour for levels. The return value is a CategoricalArray instead of raw levels.

As I am not familiar with the codebase for the newer encoders, I have simply replaced all calls levels with rawlevels, where rawlevels mimics the old behaviour: rawlevels(A) = unwrap.(levels(A)).

This PR is needed before important rollout of the CategoricalArrays="1.0" update can happen elsewhere in the MLJ ecosystem. In particular, MLJModels, needs this PR merged before it can do the update.

@EssamWisam
Copy link
Collaborator

@ablaom in the ci tests we see ERROR: LoadError: Unsatisfiable requirements detected for package CategoricalArrays [324d7699] it's unexpected for me since you also uped categorical arrays package in project.toml, right?

@ablaom
Copy link
Member Author

ablaom commented Oct 21, 2025

Sorry, my bad. This PR needs:

  • MLJBase CategoricalArrrays 1.0 update

@EssamWisam Let me ping you when this ready.

@ablaom ablaom marked this pull request as draft October 21, 2025 19:24
@ablaom ablaom marked this pull request as ready for review November 3, 2025 01:44
@ablaom ablaom closed this Nov 3, 2025
@ablaom ablaom reopened this Nov 3, 2025
@ablaom
Copy link
Member Author

ablaom commented Nov 3, 2025

Looks like document generation needs:

  • Bump CategoricalArrays to 1.0 in MLJFlux.jl

@ablaom ablaom closed this Nov 3, 2025
@ablaom ablaom reopened this Nov 3, 2025
@ablaom
Copy link
Member Author

ablaom commented Nov 3, 2025

Okay, MLJ is also a doc dependency, and we cannot update the MLJ compat entry for CategoricalArrays before MLJTransforms. Documentation has a circular dependency.

Note to self. Centralised, top-level documentation has its advantages. Otherwise, documentation needs to avoid depending on packages on which the package itself is a dependency.

No matter. Failed doc generation does not get deployed. So plan merging, and tagging the doc problem as follow-up issue.

@ablaom ablaom mentioned this pull request Nov 3, 2025
1 task
@ablaom
Copy link
Member Author

ablaom commented Nov 3, 2025

@EssamWisam Ready for a review

@EssamWisam
Copy link
Collaborator

EssamWisam commented Nov 4, 2025

I found that MLJ and others were actually redundant since each tutorial has its own toml file and removed them and now docs deploy.

Looks good to me and will merge.

@EssamWisam EssamWisam merged commit f0140f7 into dev Nov 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants