add type asserts for MA.operate! return values
#286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps ensure the MutableArithmetics contract is respected. Specifically, `MA.operate!` should always return its first argument. Why this instead of performing a stronger check with `===`? Because: * That would be more verbose * The `===` would sooner have a run time cost than a type assertion
|
Is this improving any benchmark or just some double checks ? In any case, please fix the format error and then it should bz good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps ensure the MutableArithmetics contract is respected. Specifically,
MA.operate!should always return its first argument.Why this instead of performing a stronger check with
===? Because:===would sooner have a run time cost than a type assertion