Skip to content

Fix copy of term #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Fix copy of term #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e02a3f
Fix copy of term
blegat Oct 3, 2024
1a6c369
Fix
blegat Oct 3, 2024
560b1a0
Fix
blegat Oct 4, 2024
1ee5fd6
Fix
blegat Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/default_term.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ coefficient(t::Term) = t.coefficient
monomial(t::Term) = t.monomial
term_type(::Type{<:Term{C,M}}, ::Type{T}) where {C,M,T} = Term{T,M}
monomial_type(::Type{<:Term{C,M}}) where {C,M} = M
function Base.copy(t::Term)
return Term(copy(t.coefficient), copy(t.monomial))
end

(t::Term)(s...) = substitute(Eval(), t, s)

Expand Down Expand Up @@ -84,6 +81,10 @@ function MA.mutability(::Type{Term{C,M}}) where {C,M}
end
end

# `Base.power_by_squaring` calls `Base.copy` and we want
# `t^1` to be a mutable copy of `t` so `copy` needs to be
# the same as `mutable_copy`.
Base.copy(t::Term) = MA.mutable_copy(t)
function MA.mutable_copy(t::Term)
return Term(
MA.copy_if_mutable(coefficient(t)),
Expand Down
10 changes: 10 additions & 0 deletions test/substitution.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,4 +97,14 @@ import MutableArithmetics as MA
@test MA.promote_operation(substitute, Subs, typeof(p), typeof(s)) ==
typeof(subs(p, s))
end

@testset "Issue #302 $T" for T in [BigFloat, BigInt]
Mod.@polyvar x[1:3]
t = T(1) * x[1]
@test copy(t).coefficient !== t.coefficient
@test MA.mutable_copy(t).coefficient !== t.coefficient
F = T(5) * x[1] * x[2] * x[3] + T(1) * x[1] * x[2]^2
@test subs(F, x[3] => T(0)) == x[1] * x[2]^2
@test subs(F, x[3] => 0) == x[1] * x[2]^2
end
end
Loading