fix: handle non-concrete polynomials in polynomial_merge!
#339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/poly-merge-nonconcrete
branch
2 times, most recently
from
15bd78f to
ff843bb
Compare
|
Yes, we unfortunately need to do this ^^ Can you already open the PR to DynamicPolynomials using this with the test ? You need to checkout this branch in the |
|
Opened #339 |
AayushSabharwal
force-pushed
the
as/poly-merge-nonconcrete
branch
from
ff843bb to
e4cc2bf
Compare
AayushSabharwal
force-pushed
the
as/poly-merge-nonconcrete
branch
from
e4cc2bf to
9d4a9cc
Compare
AayushSabharwal
force-pushed
the
as/poly-merge-nonconcrete
branch
from
9d4a9cc to
dd5eba0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't actually do anything until tagged, since DynamicPolynomials needs to pass the extra argument. As a result, I haven't added the test either.