Towards version 0.8 (breaking release) #171
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #171 +/- ##
==========================================
- Coverage 93.91% 93.81% -0.11%
==========================================
Files 27 28 +1
Lines 1842 1844 +2
==========================================
Hits 1730 1730
- Misses 112 114 +2 ☔ View full report in Codecov by Sentry. |
|
On exports:
Thus, the union of DomainSets 0.8 and FunctionMaps 0.1.1 is still smaller than what DomainSets used to export in 0.7. The difference lies mainly in functions that had been deprecated and have now been removed. In addition:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request mainly completes the work that was started to factor out functionality of maps. A new package FunctionMaps.jl was created. It was present as a submodule in DomainSets v0.7, but is removed in this PR.
The functionality of DomainSets is exactly the same as in the current version 0.7.15. What is breaking is the exports.
I will list below exactly what the sets of exported symbols are. The total number of exports was reduced a little bit.
LinearAlgebra.crossis no longer pirated to mean the cartesian product of domains. In version 0.8DomainSets.:×is different fromLinearAlgebra.:×. The latter is a synonym forLinearAlgebra.cross, the former is a synonym for DomainSets.cartesianproduct (which in turn simply calls theproductdomainfunctions).