Skip to content

arguments for QuasiAdj/Trans broadcasting #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2024
Merged

arguments for QuasiAdj/Trans broadcasting #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0648693
arguments for QuasiAdj/Trans broadcasting
dlfivefifty Nov 10, 2024
2efba84
Update test_quasibroadcast.jl
dlfivefifty Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "QuasiArrays"
uuid = "c4ea9172-b204-11e9-377d-29865faadc5c"
authors = ["Sheehan Olver <[email protected]>"]
version = "0.11.7"
version = "0.11.8"

[deps]
ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
Expand Down
3 changes: 2 additions & 1 deletion src/QuasiArrays.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ import LazyArrays: MemoryLayout, UnknownLayout, Mul, ApplyLayout, BroadcastLayou
LdivStyle, InvLayout, PInvLayout, sub_materialize, lazymaterialize,
_mul, rowsupport, DiagonalLayout, adjointlayout, transposelayout, conjlayout,
sublayout, call, LazyArrayStyle, layout_getindex, _broadcast2broadcastarray, _applyarray_summary, _broadcastarray_summary,
_broadcasted_mul, simplifiable, simplify, _mul_colsupport, _mul_rowsupport
_broadcasted_mul, simplifiable, simplify, _mul_colsupport, _mul_rowsupport,
_adjoint, _transpose

import Base.IteratorsMD

Expand Down
8 changes: 8 additions & 0 deletions src/quasiadjtrans.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,14 @@ BroadcastStyle(::Type{<:QuasiTranspose{<:Any,<:Inclusion}}) = LazyQuasiArrayStyl



###
# broadcast support
###

arguments(b::BroadcastLayout, A::QuasiAdjoint) = map(_adjoint, arguments(b, parent(A)))
arguments(b::BroadcastLayout, A::QuasiTranspose) = map(_transpose, arguments(b, parent(A)))


###
# adjoint concat support
###
Expand Down
8 changes: 8 additions & 0 deletions test/test_quasibroadcast.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,4 +299,12 @@ import QuasiArrays: QuasiCartesianIndex, QuasiCartesianIndices, DefaultQuasiArra
A[ones(Int)] .+= 1
@test A == [2,1,1,1]
end

@testset "adjoint arguments" begin
a = QuasiVector(randn(6), 0:0.5:2.5)
@test LazyArrays.MemoryLayout(BroadcastQuasiArray(*, 2, a)') isa LazyArrays.BroadcastLayout
@test LazyArrays.MemoryLayout(transpose(BroadcastQuasiArray(*, 2, a))) isa LazyArrays.BroadcastLayout
@test LazyArrays.arguments(BroadcastQuasiArray(*, 2, a)') == (2, a')
@test LazyArrays.arguments(transpose(BroadcastQuasiArray(*, 2, a))) == (2, transpose(a))
end
end
Loading