Skip to content

reduce permute dims to transpose/adjoint for number-values quasi matr… #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

reduce permute dims to transpose/adjoint for number-values quasi matr… #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "QuasiArrays"
uuid = "c4ea9172-b204-11e9-377d-29865faadc5c"
authors = ["Sheehan Olver <[email protected]>"]
version = "0.11.9"
version = "0.11.10"

[deps]
ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
Expand Down
4 changes: 2 additions & 2 deletions src/quasipermutedims.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@
# end

permutedims(A::AbstractQuasiMatrix) = PermutedDimsQuasiArray(A, (2,1))
permutedims(v::AbstractQuasiVector{<:Real}) = v'
permutedims(v::AbstractQuasiVector{<:Number}) = transpose(v)
permutedims(v::AbstractQuasiVecOrMat{<:Real}) = v'
permutedims(v::AbstractQuasiVecOrMat{<:Number}) = transpose(v)

Check warning on line 74 in src/quasipermutedims.jl

View check run for this annotation

Codecov / codecov/patch

src/quasipermutedims.jl#L73-L74 

Added lines #L73 - L74 were not covered by tests
# permutedims(v::AbstractQuasiVector) = reshape(v, (1, length(v)))

# function Base.showarg(io::IO, A::PermutedDimsQuasiArray{T,N,perm}, toplevel) where {T,N,perm}
Expand Down
Loading