Skip to content

Call domain(sp) rather than domain(cfs) in PeriodicLine hilbert #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mjp98
Copy link

@mjp98 mjp98 commented Jul 27, 2022

This addresses #152 by correcting calls of domain(f::AbstractVector) to domain(S::Space) in hilbert(S::Space{<:PeriodicLine},f::AbstractVector,z::Number)

Is it worth adding tests? e.g.

using ApproxFun, SingularIntegralEquations, Test
F = Fun(z->1/(1+z^2),PeriodicLine())
hilbertF = z-> -z/(1+z^2)
z = pi
@test hilbert(F,z)  hilbertF(z)

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.26%. Comparing base (9e3e0bb) to head (60e0736).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/periodicline.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   55.29%   55.26%   -0.03%     
==========================================
  Files          34       34              
  Lines        2400     2401       +1     
==========================================
  Hits         1327     1327              
- Misses       1073     1074       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant