Skip to content

Conversation

@Tokazama
Copy link
Member

@Tokazama Tokazama commented Nov 7, 2022

This was type piracy after the move of StaticInt to Static.jl.
Pending SciML/Static.jl#88, this PR should solve that issue without any breaking changes for packages depending on ArrayInterface.jl.

This is complimentary to SciML/Static.jl#88 and
would be a big move in disentangling static types from ArrayInterface
@Tokazama Tokazama marked this pull request as ready for review November 15, 2022 10:41
@Tokazama Tokazama marked this pull request as draft November 15, 2022 10:42
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #366 (5d41ce5) into master (87e65bc) will increase coverage by 89.95%.
The diff coverage is 94.23%.

@@             Coverage Diff             @@
##           master     #366       +/-   ##
===========================================
+ Coverage    0.00%   89.95%   +89.95%     
===========================================
  Files           9        9               
  Lines        1335     1155      -180     
===========================================
+ Hits            0     1039     +1039     
+ Misses       1335      116     -1219     
Impacted Files Coverage Δ
src/ArrayInterface.jl 85.71% <50.00%> (+85.71%) ⬆️
src/size.jl 91.52% <90.90%> (+91.52%) ⬆️
src/indexing.jl 83.61% <95.65%> (+83.61%) ⬆️
src/array_index.jl 100.00% <100.00%> (+100.00%) ⬆️
src/axes.jl 92.14% <100.00%> (+92.14%) ⬆️
src/dimensions.jl 93.87% <100.00%> (+93.87%) ⬆️
src/ranges.jl 95.83% <100.00%> (+95.83%) ⬆️
src/stridelayout.jl 89.89% <100.00%> (+89.89%) ⬆️
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Tokazama Tokazama marked this pull request as ready for review November 16, 2022 04:23
@Tokazama
Copy link
Member Author

@chriselrod , I think the only issue you might run into with this one is that _pick_range is gone, so I put a deprecation in for that so it would be mildly annoying instead of breaking.

@chriselrod
Copy link
Collaborator

@chriselrod , I think the only issue you might run into with this one is that _pick_range is gone, so I put a deprecation in for that so it would be mildly annoying instead of breaking.

StrideArrays.jl uses it, but none of the other repos that I saw.
It also depends on Static.jl, so the same PR bumping that can remove the use of ArrayInterface._pick_range.

@Tokazama
Copy link
Member Author

@chriselrod , I think the only issue you might run into with this one is that _pick_range is gone, so I put a deprecation in for that so it would be mildly annoying instead of breaking.

StrideArrays.jl uses it, but none of the other repos that I saw. It also depends on Static.jl, so the same PR bumping that can remove the use of ArrayInterface._pick_range.

Got it. I'll remove the deprecation, push this through, and then take a look at StrideArrays.jl

@Tokazama Tokazama merged commit 1b64411 into master Nov 17, 2022
@Tokazama Tokazama deleted the rm-ranges branch November 17, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants