Skip to content

Conversation

ogauthe
Copy link
Contributor

@ogauthe ogauthe commented Apr 9, 2025

This PR generalizes blocked ranges to any integer type, follow-up to #405
fix #454

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.62%. Comparing base (a80fcf7) to head (3a6e33c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #455       +/-   ##
===========================================
+ Coverage    0.00%   93.62%   +93.62%     
===========================================
  Files          18       19        +1     
  Lines        1642     1664       +22     
===========================================
+ Hits            0     1558     +1558     
+ Misses       1642      106     -1536     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman mtfishman changed the title fix non Int64 ranges Generalize more functions to non-Int64 ranges Apr 9, 2025
@mtfishman
Copy link
Collaborator

Can you bump the version? I think this warrants a minor version bump (to v1.6.0).

@mtfishman
Copy link
Collaborator

@dlfivefifty @jishnub does this look ok to you? If so, do you mind if I merge and register it?

@jishnub
Copy link
Member

jishnub commented Apr 9, 2025

Looks fine to me, please go ahead

@mtfishman mtfishman merged commit b55c7a4 into JuliaArrays:master Apr 9, 2025
16 checks passed
@ogauthe ogauthe deleted the Integer branch April 9, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

failures for non-Int64 ranges

3 participants