Skip to content

Conversation

mtfishman
Copy link
Collaborator

@mtfishman mtfishman commented Apr 28, 2025

This defines copy(::BlockIndexRange), which fixes #404.

Before, copy(::BlockIndexRange) was outputting a Vector{<:BlockIndex}, which was leading to the behavior reported in #404. I think this definition of copy makes sense, since it is similar to the definition of copy for unit ranges (i.e. it just returns the unit range instead of collecting into a Vector).

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.64%. Comparing base (4059149) to head (2db5671).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files          19       19           
  Lines        1667     1668    +1     
=======================================
+ Hits         1561     1562    +1     
  Misses        106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman mtfishman merged commit b167ede into JuliaArrays:master Apr 28, 2025
16 checks passed
@mtfishman mtfishman deleted the copy_blockindexrange branch April 28, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mortar([Block(1)[1:2], Block(2)[1:2]])[Block(1)] has type Vector{BlockIndex{1}} instead of BlockIndexRange{1}

3 participants