Skip to content

Preserve infinite step ranges in views #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Preserve infinite step ranges in views #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb51445
Preserve infinite step ranges in views
jishnub Dec 2, 2024
446276d
Remove unnecessary method
jishnub Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/infrange.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,10 @@
parent(Ac)[j]
end

# views may preserve InfStepRanges
Base.@propagate_inbounds Base.view(r::InfStepRange, i::AbstractUnitRange{<:Integer}) = r[i]
Base.@propagate_inbounds Base.view(r::InfStepRange, i::InfStepRange{<:Integer}) = r[i]
Base.@propagate_inbounds Base.view(r::InfStepRange, i::StepRange{<:Integer}) = r[i]

Check warning on line 290 in src/infrange.jl

View check run for this annotation

Codecov / codecov/patch

src/infrange.jl#L288-L290 

Added lines #L288 - L290 were not covered by tests

show(io::IO, r::InfUnitRange) = print(io, repr(first(r)), ':', repr(∞))
show(io::IO, r::OneToInf{Int}) = print(io, "OneToInf()")
Expand Down
12 changes: 11 additions & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,16 @@ end
@test (1:-1:-∞)[1:∞] == 1:-1:-∞
end

@testset "view(InfStepRange, inf-range)" begin
r = 2:5:∞
@test view(r, axes(r,1)) === r
@test view(r, 1:1:∞) === r
@test view(r, 2:2:∞) === 7:10:∞
r2 = 2:5:10_000 # arbitrary high upper cutoff
@test view(r, 4:10) == view(r2, 4:10)
@test view(r, 4:7:50) == view(r2, 4:7:50)
end

@testset "OneToInf" begin
r = OneToInf()
@test !isempty(r)
Expand Down Expand Up @@ -1265,4 +1275,4 @@ end
include("test_infconv.jl")
include("test_infblock.jl")
include("test_infbanded.jl")
include("test_infblockbanded.jl")
include("test_infblockbanded.jl")
Loading