WIP: Implement insert! and deleteat! for OffsetVectors#137
WIP: Implement insert! and deleteat! for OffsetVectors#137garrison wants to merge 1 commit intoJuliaArrays:masterfrom
Conversation
|
Just found #55 (comment), which did not turn up in my earlier repository search. I still believe implementing |
|
As you can tell from your readings, I'm mixed on this. If I had to take a stance, it would be "against by a hair." Here's why:
|
|
@timholy What about |
|
We can have this if there's enough enthusiasm. I just think that the consensus has never been clear. Lots of people initially think "why isn't that implemented? I'll add it!" and then once the concerns are raised most eem to agree that it's not obvious we want it. If someone makes a sufficiently clear case and is willing to document the behavior carefully, we can do things like this. But the principle of "do no harm" holds me back from adding this until someone really pushes a strong argument. |
I consider this to be incomplete. I have not, for instance, thought carefully about whether I am referring to the
axesin the most appropriate way, but hey, all tests pass! Also, ideally the offset indices will be used in the exception message when the index is out of range; right now, the indices of the parent array are instead provided, and this can be confusing.