Skip to content

Remove parent checks in reshape tests #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jishnub merged 2 commits into from
Dec 3, 2024
Merged

Remove parent checks in reshape tests #363

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69b884f
Remove parent checks in `reshape` tests
jishnub Dec 2, 2024
8c4cfcb
Reinstate a parent equality check
jishnub Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1755,7 +1755,7 @@ end

B = reshape(A0, -10:-9, 9:10)
@test isa(B, OffsetArray{Int,2})
@test parent(B) === A0
@test parent(B) == A0
@test axes(B) == IdentityUnitRange.((-10:-9, 9:10))
B = reshape(A, -10:-9, 9:10)
@test isa(B, OffsetArray{Int,2})
Expand Down Expand Up @@ -1786,7 +1786,7 @@ end
# reshape with one Colon for AbstractArrays
B = reshape(A0, -10:-9, :)
@test B isa OffsetArray{Int,2}
@test parent(B) === A0
@test parent(B) == A0
@test no_offset_axes(B, 1) == -10:-9
@test axes(B, 2) == axes(A0, 2)

Expand All @@ -1807,17 +1807,14 @@ end
# pop the parent
B = reshape(A, size(A))
@test B == A0
@test parent(B) === A0
B = reshape(A, (Base.OneTo(2), 2))
@test B == A0
@test parent(B) === A0
B = reshape(A, (2,:))
@test B == A0
@test parent(B) === A0

# julialang/julia #33614
A = OffsetArray(-1:0, (-2,))
@test reshape(A, :) === A
@test reshape(A, :) == A
Arsc = reshape(A, :, 1)
Arss = reshape(A, 2, 1)
@test Arsc[1,1] == Arss[1,1] == -1
Expand Down
Loading