Skip to content

feat: add Adapt.parent_type dispatch #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jishnub merged 2 commits into from
Mar 19, 2025
Merged

feat: add Adapt.parent_type dispatch #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
948d12d
feat: add Adapt.parent_type dispatch
avik-pal Mar 18, 2025
6745abb
fix: allow old versions not having the function
avik-pal Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ext/OffsetArraysAdaptExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,9 @@ using OffsetArrays, Adapt
import Adapt
Adapt.adapt_structure(to, O::OffsetArray) = OffsetArrays.parent_call(x -> Adapt.adapt(to, x), O)

@static if isdefined(Adapt, :parent_type)
# To support Adapt 3.0 which doesn't have parent_type defined
Adapt.parent_type(::Type{OffsetArray{T,N,AA}}) where {T,N,AA} = AA
end

end
4 changes: 4 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2500,6 +2500,10 @@ end
s_arr = adapt(SMatrix{3,3}, arr)
@test parent(s_arr) isa SArray
@test arr == adapt(Array, s_arr)

if isdefined(Adapt, :parent_type)
@test Adapt.parent_type(typeof(arr)) == typeof(arr.parent)
end
end

@testset "Pointer" begin
Expand Down
Loading