Skip to content

implement unwrap_type from Adapt #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jishnub merged 2 commits into from
Apr 13, 2025
Merged

implement unwrap_type from Adapt #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
241b1b2
implement unwrap_type from Adapt
vchuravy Apr 11, 2025
02bd5c4
fixup! implement unwrap_type from Adapt
vchuravy Apr 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ext/OffsetArraysAdaptExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Adapt.adapt_structure(to, O::OffsetArray) = OffsetArrays.parent_call(x -> Adapt.
@static if isdefined(Adapt, :parent_type)
# To support Adapt 3.0 which doesn't have parent_type defined
Adapt.parent_type(::Type{OffsetArray{T,N,AA}}) where {T,N,AA} = AA
Adapt.unwrap_type(W::Type{<:OffsetArray}) = unwrap_type(parent_type(W))
end

end
4 changes: 4 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2507,8 +2507,12 @@ end
@test parent(s_arr) isa SArray
@test arr == adapt(Array, s_arr)

arr2 = OffsetArray(view(rand(5, 5), 2:4, 2:4), -1:1, -1:1)

if isdefined(Adapt, :parent_type)
@test Adapt.parent_type(typeof(arr)) == typeof(arr.parent)
@test Adapt.unwrap_type(typeof(arr)) == typeof(arr.parent)
@test Adapt.unwrap_type(typeof(arr2)) == typeof(arr.parent)
end
end

Expand Down
Loading