-
Notifications
You must be signed in to change notification settings - Fork 11
Swapped out ItemGraphs -> Graphs for compatibility updates #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Mosè Giordano <[email protected]>
|
Tests seem to be failing here. |
|
Thanks for checking. Would it be possible for someone more familiar with this project to take a look at the changes? The tests are failing for me too, and I am not sure where the issue is. |
|
Tests are passing on main though |
|
Yup, the issue is definitely in my changes. The ItemGraphs compatibility is only an issue in one file, if someone else is willing to take a look that would be great |
|
It's entirely in TimeScales.jl |
|
I pushed a patch that fixes the tests. The problem was that Sorry for the long delay @leerosenthalj. I have been completely under water for the better part of two years now... |
Co-authored-by: Mosè Giordano <[email protected]>
Co-authored-by: Mosè Giordano <[email protected]>
Co-authored-by: Mosè Giordano <[email protected]>
|
Yay, all green now, thanks everybody! |
Initial tests didn't break anything but some compatibility details in the Project.toml might need to be changed