Skip to content

Accept status in fits_get_colnum to continue search#89

Open
jishnub wants to merge 1 commit intomasterfrom
jishnub/fits_get_colnum
Open

Accept status in fits_get_colnum to continue search#89
jishnub wants to merge 1 commit intomasterfrom
jishnub/fits_get_colnum

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Jun 1, 2025

This matches the functionality provided by CFITSIO. A non-zero status does not necessarily indicate an error in this function, and the status may be used as an input to continue the search.

@codecov
Copy link

codecov bot commented Jun 1, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.85%. Comparing base (4124926) to head (09ab8a1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/CFITSIO.jl 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   96.17%   95.85%   -0.33%     
==========================================
  Files           1        1              
  Lines         890      893       +3     
==========================================
  Hits          856      856              
- Misses         34       37       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub
Copy link
Member Author

jishnub commented Jun 5, 2025

Looks like FITSIO.jl explicitly expects this to error. Perhaps we need a new flag to preserve this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant