Add XSPEC model string macro (closes #187)#242
Open
aditya-pandey-dev wants to merge 1 commit intoJuliaAstro:mainfrom
Open
Add XSPEC model string macro (closes #187)#242aditya-pandey-dev wants to merge 1 commit intoJuliaAstro:mainfrom
aditya-pandey-dev wants to merge 1 commit intoJuliaAstro:mainfrom
Conversation
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
==========================================
+ Coverage 55.69% 57.49% +1.79%
==========================================
Files 39 39
Lines 2632 2550 -82
==========================================
Hits 1466 1466
+ Misses 1166 1084 -82 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
Author
|
@fjebaker I have raise a PR related to this issue can you please review the PR |
Member
|
Hello @aditya-pandey-dev thanks for your PR! I am away at a conference this week so it will take me some time to review this. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements bidirectional translation between XSPEC model strings and
XSPECModels.jl types, as requested in #187.
Changes
lib/XSPECModels/src/xspec_string.jlβ new file:parse_xspec_model_string(str): runtime XSPEC string β JuliaExprxspec"..."string macro: compile-time, zero overheadxspec_model_string(model): reverse directionXSPEC_MODEL_NAMES: 20 verified model mappingslib/XSPECModels/src/XSPECModels.jlβ include + export new APIlib/XSPECModels/test/test-xspec-string.jlβ full test suitelib/XSPECModels/test/runtests.jlβ include new testsdocs/src/transitioning-from-xspec.mdβ complete guide for XSPEC usersdocs/make.jlβ add page to navigationdocs/src/models/xspec-models.mdβ mention new featurerunning_example_xspec_strings.jlβ self-contained demoExample