Skip to content

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Aug 13, 2025

Modernizes Coverage.jl to work with official uploaders from Codecov and Coveralls, replacing the deprecated direct upload functionality. The modernization maintains compatibility.

Developed with Claude.

Copilot

This comment was marked as resolved.

…ove error handling

- Add architecture support (aarch64/arm64) for Codecov and Coveralls downloaders
- Fix file permissions to 0o555 (read/execute only)
- Improve error handling with proper sprint(Base.display_error, e)
- Remove unused YAML generation system as suggested
- Implement backward compatibility for legacy Codecov.submit/Coveralls.submit APIs
- Fix Julia run() command syntax for cross-platform compatibility
- Preserve CI environment detection behavior in legacy interfaces
- Update README urgency level from IMPORTANT to NOTE
@IanButterworth
Copy link
Member Author

Trying this out here JuliaCI/julia-buildkite#475

@IanButterworth
Copy link
Member Author

A wrinkle here is that at least our macOS CI runners don't let you run homebrew, and Coveralls don't provide macOS binaries directly. Not sure what we can do for macOS.

@vtjnash
Copy link
Member

vtjnash commented Aug 18, 2025

The CI here is also failing (#define EBADARCH 86 /* Bad CPU type in executable */)

Sadly, brew wants to run all of openssl tests in order to install locally, which is a huge percentage of the actual time (and size)
@IanButterworth
Copy link
Member Author

Thanks @vtjnash 👍

@IanButterworth
Copy link
Member Author

Did I need to change something here? Seems to have not worked? https://buildkite.com/julialang/julia-buildkite-scheduled/builds/1397#0198afd5-474a-42a2-a2f8-9bdc4ded947d

@vtjnash
Copy link
Member

vtjnash commented Aug 23, 2025

It is just using the wrong brew, since Claude first checks the path. Honestly we possibly should just add this to Yggy, since their build system and brew is quite a mess and compiles down to a half a gigabyte installer. We could likely do far better in Julia than their crystal/zig/docker/brew build stack for their ruby script

@IanButterworth IanButterworth marked this pull request as ready for review August 28, 2025 20:29
@IanButterworth IanButterworth merged commit f25c6ca into master Aug 29, 2025
9 of 11 checks passed
@IanButterworth IanButterworth deleted the ib/modernize branch August 29, 2025 01:52
kodiakhq bot pushed a commit to JuliaCI/julia-buildkite that referenced this pull request Aug 29, 2025
Fixes #473 

- Uses the new Coverage.jl API
JuliaCI/Coverage.jl#349
- Handles parallel jobs in the way that coveralls wants us to
- Fixes collecting coverage for the Compiler julia dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants