-
Notifications
You must be signed in to change notification settings - Fork 65
Modernize #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize #349
Conversation
…ove error handling - Add architecture support (aarch64/arm64) for Codecov and Coveralls downloaders - Fix file permissions to 0o555 (read/execute only) - Improve error handling with proper sprint(Base.display_error, e) - Remove unused YAML generation system as suggested - Implement backward compatibility for legacy Codecov.submit/Coveralls.submit APIs - Fix Julia run() command syntax for cross-platform compatibility - Preserve CI environment detection behavior in legacy interfaces - Update README urgency level from IMPORTANT to NOTE
Trying this out here JuliaCI/julia-buildkite#475 |
A wrinkle here is that at least our macOS CI runners don't let you run homebrew, and Coveralls don't provide macOS binaries directly. Not sure what we can do for macOS. |
The CI here is also failing ( |
Sadly, brew wants to run all of openssl tests in order to install locally, which is a huge percentage of the actual time (and size)
Thanks @vtjnash 👍 |
Did I need to change something here? Seems to have not worked? https://buildkite.com/julialang/julia-buildkite-scheduled/builds/1397#0198afd5-474a-42a2-a2f8-9bdc4ded947d |
It is just using the wrong brew, since Claude first checks the path. Honestly we possibly should just add this to Yggy, since their build system and brew is quite a mess and compiles down to a half a gigabyte installer. We could likely do far better in Julia than their crystal/zig/docker/brew build stack for their ruby script |
d3c34f6
to
eb14afc
Compare
22a9919
to
4a489fb
Compare
8c63f9a
to
18bc1d3
Compare
045f398
to
bdd667b
Compare
Fixes #473 - Uses the new Coverage.jl API JuliaCI/Coverage.jl#349 - Handles parallel jobs in the way that coveralls wants us to - Fixes collecting coverage for the Compiler julia dir
Modernizes Coverage.jl to work with official uploaders from Codecov and Coveralls, replacing the deprecated direct upload functionality. The modernization maintains compatibility.
Developed with Claude.