Skip to content

gitlab-ci.yml file prefix#372

Open
antonhinneck wants to merge 2 commits intoJuliaCI:masterfrom
antonhinneck:GitLabCiFilePrefix
Open

gitlab-ci.yml file prefix#372
antonhinneck wants to merge 2 commits intoJuliaCI:masterfrom
antonhinneck:GitLabCiFilePrefix

Conversation

@antonhinneck
Copy link
Copy Markdown

@antonhinneck antonhinneck commented Oct 26, 2022

Hi,
PkgTemplates.jl suits my needs to generate new projects with CI pipeline perfectly.
However, I need to be able to make further modifications to gitlab-ci.yml files (set variables during package creation).
While a custom template could be created, addressing this directly in PkgTemplates.jl would be

  • extremly straightforward and
  • one would not have to maintain an additional template, beyond what is already in this package.

With this PR, one could exemplarily set the http_proxy using GitLabCI like so:

tpl = Template(;
    dir="./",
    host="host.com",
    user="antonhinneck",
    plugins=[Git(), 
    GitLabCI(;coverage=true,
    file_prefix="variables:\n\thttp_proxy: 10.0.0.1\n")]
)

tpl("Pkg.jl")

All tests pass. Would this be sensible for the scope of this package?

Best,
Anton

Z004N5CH added 2 commits October 26, 2022 23:34
…view dict, added variable to template gitlab-ci.yml, included option in test
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 26, 2022

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@gdalle
Copy link
Copy Markdown
Collaborator

gdalle commented Dec 18, 2023

I don't see a reason not to accept this. Can you add documentation and tests for this? The reference tests compare generated packages to a series of "fixtures", and they are only run for Julia 1.7.2. I suggest you modify the WackyOptions test suite accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants