Skip to content

fix(license): clarify interactive license names#524

Open
Kemalau wants to merge 1 commit intoJuliaCI:masterfrom
Kemalau:clawoss/docs/license-prompt-448
Open

fix(license): clarify interactive license names#524
Kemalau wants to merge 1 commit intoJuliaCI:masterfrom
Kemalau:clawoss/docs/license-prompt-448

Conversation

@Kemalau
Copy link
Copy Markdown

@Kemalau Kemalau commented Mar 16, 2026

Closes #448

Why

The interactive license prompt currently shows bare abbreviations such as ASL and MPL, which makes it easy to misread the intended license. This change keeps the saved license keys unchanged while showing expanded names in the interactive menu.

What changed

  • render the license picker entries as abbreviation - full name
  • keep the existing return values and ordering intact
  • extend the interactive test to assert the clearer prompt text

Verification

  • static review of the focused diff
  • local execution of Julia tests was not possible in this environment because julia is not installed (julia: command not found)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.28%. Comparing base (4847597) to head (7735b3a).

Files with missing lines Patch % Lines
src/plugins/license.jl 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4847597) and HEAD (7735b3a). Click for more details.

HEAD has 94 uploads less than BASE
Flag BASE (4847597) HEAD (7735b3a)
103 9
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage   94.11%   88.28%   -5.84%     
==========================================
  Files          24       24              
  Lines         748      751       +3     
==========================================
- Hits          704      663      -41     
- Misses         44       88      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oxinabox
Copy link
Copy Markdown
Collaborator

I think we should come back to this after doing
#448 (comment)

@oxinabox
Copy link
Copy Markdown
Collaborator

If we think we still want this now that we are using SPIX names, can you rebase this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

License ambiguity

2 participants