Fix misc shellcheck complaints and run shellcheck on CI#450
Merged
fredrikekre merged 2 commits intomainfrom Jun 11, 2025
Merged
Fix misc shellcheck complaints and run shellcheck on CI#450fredrikekre merged 2 commits intomainfrom
fredrikekre merged 2 commits intomainfrom
Conversation
fredrikekre
force-pushed
the
fe/shellcheck
branch
3 times, most recently
from
99d6361 to
da41a00
Compare
fredrikekre
force-pushed
the
fe/shellcheck
branch
9 times, most recently
from
d51c0c0 to
5ede551
Compare
fredrikekre
force-pushed
the
fe/shellcheck
branch
from
5ede551 to
9c20d1a
Compare
Member
Author
|
This works now. It caught some problematic issues so I think it is worth adding shellcheck to CI like here. |
DilumAluthge
approved these changes
Jun 9, 2025
Member
Author
|
Can I just merge or does it have to go through the mergebot in order to not mess with the signatures? |
Member
|
Nope you can just merge directly. The mergebot is just for convenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.