-
Notifications
You must be signed in to change notification settings - Fork 7
way less spammy errors on bad requests. #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
juliohm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs tests.
fix: added tests
Co-authored-by: Júlio Hoffimann <[email protected]>
|
Tests are failing on GitHub Actions for some reason. Appreciate if you could investigate further. |
|
There seems to be something wrong with the setup of the api keys. The error is about the request url not being a valid uri. It seems |
|
We fixed CI builds before the latest release, and added new secrets. I'll
double check soon. Thanks for looking into it.
Em qui., 16 de jan. de 2025, 03:57, cschen ***@***.***>
escreveu:
… There seems to be something wrong with the setup of the api keys.
The error is about the request url not being a valid uri. It seems
creds["url"]is empty.
—
Reply to this email directly, view it on GitHub
<#60 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZQW3KX4A244FLHBNWS7H32K5J7BAVCNFSM6AAAAABVG47XEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJUGY3TCNJSGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I've edited the README in the master branch, and CI passed successfully. Could this be caused by the fact that the PR is from a fork? |
|
Could this be relevant: https://stackoverflow.com/questions/73866908/github-actions-main-repository-secret-not-picked-up-from-pull-request-build ? from the logs it really seems like |
|
That is interesting. I will test locally and merge if tests are ok 👍🏽 |
This is rather minor and left for last.
It simply adds a check to grab the error in case of a badly formatted request that cuts down on the spam that HTTP.jl does, and provides a more descriptive error other than "422: unprocessable event"