Refactor not_iterator_of_pairs to stop using InteractiveUtils
#936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeff and Oscar agree this should be equivalent (and precompilable!)
asinghvi17
commented
Apr 30, 2025
asinghvi17
commented
May 1, 2025
asinghvi17
commented
May 1, 2025
oxinabox
approved these changes
May 1, 2025
oxinabox
reviewed
May 1, 2025
Member
|
It would be good if the coverage was complete |
asinghvi17
commented
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jeff and Oscar agree this should be equivalent (and precompilable!). It uses Base.isiterable instead.
This also adds a fast path checking
eltypeif at all possible. Only if the eltype is not Any do we use the fast path. But that should ideally also cut down the time taken to construct a priority queue.