Skip to content

Refactor not_iterator_of_pairs to stop using InteractiveUtils #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oxinabox merged 9 commits into from
May 2, 2025
Merged

Refactor not_iterator_of_pairs to stop using InteractiveUtils #936

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7582ea2
do not use InteractiveUtils
asinghvi17 Apr 30, 2025
60feec6
Update src/dict_support.jl
asinghvi17 Apr 30, 2025
6625cdf
Update Project.toml
asinghvi17 Apr 30, 2025
dd50639
Update src/dict_support.jl
asinghvi17 May 1, 2025
06aea47
Update src/dict_support.jl
asinghvi17 May 1, 2025
f1db618
Simpler logic and fast path for known concrete-ish eltypes
asinghvi17 May 1, 2025
96ce804
add tests for full coverage
asinghvi17 May 1, 2025
1be4fef
add missing begin
oxinabox May 1, 2025
81eef60
Update src/dict_support.jl
asinghvi17 May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ uuid = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"
version = "0.19.0-DEV"

[deps]
InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
OrderedCollections = "bac558e1-5e72-5ebc-8fee-abe8a469f55d"

[compat]
Expand Down
7 changes: 2 additions & 5 deletions src/dict_support.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
# support functions

using InteractiveUtils: methodswith

function not_iterator_of_pairs(kv)
return any(x->isempty(methodswith(typeof(kv), x, true)),
[iterate]) ||
function not_iterator_of_pairs(kv::T) where T
return Base.isiterable(T) &&
any(x->!isa(x, Union{Tuple,Pair}), kv)
end
Loading