Skip to content

Avoid unnecessary hash lookups in trie.jl #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oxinabox merged 2 commits into from
Mar 25, 2025
+3 −9
Merged

Avoid unnecessary hash lookups in trie.jl #933

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fae1b9d
optimize trie.jl
AzamatB Mar 24, 2025
0fb1b9a
Update src/trie.jl
AzamatB Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/trie.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,7 @@ function Base.setindex!(t::Trie{K,V}, val, key) where {K,V}
value = convert(V, val) # we don't want to iterate before finding out it fails
node = t
for char in key
if !haskey(node.children, char)
node.children[char] = Trie{K,V}()
end
node = node.children[char]
node = get!(Trie{K,V}, node.children, char)
end
node.is_key = true
node.value = value
Expand All @@ -53,11 +50,8 @@ end
function subtrie(t::Trie, prefix)
node = t
for char in prefix
if !haskey(node.children, char)
return nothing
else
node = node.children[char]
end
node = get(node.children, char, nothing)
isnothing(node) && return nothing
end
return node
end
Expand Down
Loading