Skip to content

Remove outdated Iterators.reverse definition #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oscardssmith merged 1 commit into from
May 1, 2025
+0 −3
Merged

Remove outdated Iterators.reverse definition #939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/stack.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
- `blksize::Integer` unused

# Examples
```jldoctest

Check failure on line 13 in src/stack.jl

View workflow job for this annotation

GitHub Actions / Documentation 

doctest failure in src/stack.jl:13-19

```jldoctest
julia> s_int = Stack{Int64}() # create a stack with Int64 elements
Stack{Int64}([Int64[]])

julia> s_float = Stack{Float64}() # create a stack with Float64 elements
Stack{Float64}(Float64[])
```

Subexpression:

s_int = Stack{Int64}() # create a stack with Int64 elements

Evaluated output:

Stack{Int64}(Int64[])

Expected output:

Stack{Int64}([Int64[]])


  diff = 
    Warning: Diff output requires color.
    Stack{Int64}([Int64[]])Stack{Int64}(Int64[])
julia> s_int = Stack{Int64}() # create a stack with Int64 elements
Stack{Int64}([Int64[]])

Expand Down Expand Up @@ -57,7 +57,7 @@
the stack).

# Example
```jldoctest

Check failure on line 60 in src/stack.jl

View workflow job for this annotation

GitHub Actions / Documentation 

doctest failure in src/stack.jl:60-73

```jldoctest
julia> s = Stack{Float32}()
Stack{Float32}([Float32[]])

julia> for i in range(1, 0.2, 5)
           push!(s, i)
       end

julia> s
Stack{Float32}[Float32[1.0, 0.8, 0.6, 0.4, 0.2])

julia> first(s)
0.2f0
```

Subexpression:

s

Evaluated output:

Stack{Float32}(Float32[1.0, 0.8, 0.6, 0.4, 0.2])

Expected output:

Stack{Float32}[Float32[1.0, 0.8, 0.6, 0.4, 0.2])


  diff = 
    Warning: Diff output requires color.
    Stack{Float32}[Float32[1.0, Stack{Float32}(Float32[1.0, 0.8, 0.6, 0.4, 0.2])

Check failure on line 60 in src/stack.jl

View workflow job for this annotation

GitHub Actions / Documentation 

doctest failure in src/stack.jl:60-73

```jldoctest
julia> s = Stack{Float32}()
Stack{Float32}([Float32[]])

julia> for i in range(1, 0.2, 5)
           push!(s, i)
       end

julia> s
Stack{Float32}[Float32[1.0, 0.8, 0.6, 0.4, 0.2])

julia> first(s)
0.2f0
```

Subexpression:

s = Stack{Float32}()

Evaluated output:

Stack{Float32}(Float32[])

Expected output:

Stack{Float32}([Float32[]])


  diff = 
    Warning: Diff output requires color.
    Stack{Float32}([Float32[]])Stack{Float32}(Float32[])
julia> s = Stack{Float32}()
Stack{Float32}([Float32[]])

Expand Down Expand Up @@ -127,9 +127,6 @@

Base.iterate(st::Stack, s...) = iterate(Iterators.reverse(st.store), s...)

Iterators.reverse(s::Stack{T}) where {T} = DequeIterator{T}(s.store)


"""
==(x::Stack, y::Stack)

Expand Down
Loading